exception during conversion of exception is not handled properly

Description

i guess there a tiny typo in EnginePrivate.remoteHandleException(..) - current code:
try
{
ScriptBuffer script = new ScriptBuffer();
script.appendScript("dwr.engine._remoteHandleException(\'")
.appendScript(batchId)
.appendScript("\',\'")
.appendScript(callId)
.appendScript("\',")
.appendData(ex)
.appendScript(");");

conduit.addScript(script);
}
catch (MarshallException mex)
{
ScriptBuffer script = new ScriptBuffer();
script.appendScript("dwr.engine._remoteHandleException(\'")
.appendScript(batchId)
.appendScript("\',\'")
.appendScript(callId)
.appendScript("\',")
//############# THE NEXT LINE SHOULD HAVE BEEN .appendData(mex) - mex - not ex....###########
.appendData(ex)
.appendScript(");");

addScriptWithoutException(conduit, script);
}

Activity

Show:
Mike Wilson
September 30, 2009, 9:26 PM

This looks fair. I'm curious on what problem occured that made you find it? (It would be good to have something to add as a test case.)
David: should we double-check with Joe whether this is the "right" fix?

David Marginian
September 30, 2009, 11:44 PM

I agree that it is a valid issue (surely not a major priority). It seems pretty clear that it is a copy/paste error so I don't think we need to ask Joe (although feel free to).

David Marginian
October 1, 2009, 5:53 AM

This problem does not exist in 3.x (trunk).

I checked in a fix for it into Branch_2_0. Mike, I know you had talked about pushing a 2.0.6 out some time so this will be in there if we do.

Mike Wilson
October 1, 2009, 7:47 PM

The fix was needed in another method so I've checked in that as well. Might be as good time as any to get 2.0.6 out?

David Marginian
October 4, 2009, 5:56 AM

Thanks Mike. I remember there was another issue you wanted to resolve for 2.0.6. I will look it up and email you privately. For now I am going to close this issue.

Assignee

David Marginian

Reporter

Kai Lilleby

Labels

None

Documentation Required

No

Components

Fix versions

Affects versions

Priority

Trivial
Configure