A timeout with id 0 is not cleared

Description

This is a classic 0 vs. null bug which only manifests in environments where timeouts have integer IDs counting from 0. I've observed this on 2.0.5 and none of the issues closed for 2.0.6 seem to address this, so here is a tiny diff:

@@ -1024,7 +1024,7 @@
}

// Timeout tidyup

  • if (batch.timeoutId) {
    + if (batch.timeoutId != null) {
    clearTimeout(batch.timeoutId);
    delete batch.timeoutId;
    }

Activity

Show:
David Marginian
February 8, 2010, 5:46 AM

I have just fixed this for 3.x and 2.x. You can check our CI site for the next build: http://ci.directwebremoting.org/bamboo/. I am going to wait to resolve this because I need to determine what to do with versioning.

Mike Wilson
February 18, 2010, 1:10 AM

Thanks for finding this, Logi!
David: we might as well plan for a 2.0.7 and use that as "Fix version"?

Assignee

David Marginian

Reporter

Logi Ragnarsson

Labels

None

Documentation Required

No

Components

Fix versions

Affects versions

Priority

Minor
Configure